Updates developer guide and removes integtest.sh #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion script Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
…/opensearch-build#497 Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
cliu123,
cwperks,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
10 tasks
10 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3844 +/- ##
==========================================
- Coverage 66.58% 66.58% -0.01%
==========================================
Files 298 298
Lines 21188 21188
Branches 3453 3453
==========================================
- Hits 14108 14107 -1
- Misses 5363 5364 +1
Partials 1717 1717 |
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
willyborankin
previously approved these changes
Dec 14, 2023
2 tasks
There was a problem hiding this comment.
Thanks DC; I left some suggestions on wording. I am not sure if you are intending to use "password" as a proper noun or not. I assume no, in which case I would suggest taking a peak at my suggestions. If you do mean it to be a proper noun, you are missing capitalization in a couple spots. (First comment and then later)
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
|
@scrawfor99 Addressed all feedback. @willyborankin would you please re-review this? |
willyborankin
previously approved these changes
Dec 14, 2023
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
willyborankin
approved these changes
Dec 14, 2023
|
CI failures address via #3850 |
peternied
requested changes
Dec 14, 2023
There was flaky test introduced in the original change around a static variable. Since this was tested in multiple tests, sometimes value wouldn't reset. I have explicitly reset the value to the state it is expected in before the test is run. This issue is now fixed in #3850. I will merge main and re-push. |
|
@scrawfor99 @peternied mind giving this PR another lookeru? |
peternied
approved these changes
Dec 15, 2023
DarshitChanpura
added a commit
to DarshitChanpura/security
that referenced
this pull request
Dec 15, 2023
…3844) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
cwperks
pushed a commit
that referenced
this pull request
Dec 18, 2023
…t for Bundled JDK for this tool and updates DEVELOPER_GUIDE.md (#3845) ### Description Backports following commits related to demo configuration tool from main to 2.x: - [x] [17748b9](17748b9) from #3669 - [x] [4496440](4496440) from #3734 - [x] [06d8c29](06d8c29) from #3777 - [x] [e698315](e698315) from #3807 - [x] [9d11524](9d11524) from #3843 - [x] [62aed21](62aed21) from #3850 - [x] [ceabe13](ceabe13) from #3844 ### Issues Resolved - Related to #3827 ### Testing - automated tests ### Check List - [x] New functionality includes testing - [x] New functionality has been documented - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
prabhask5
pushed a commit
to prabhask5/opensearch-security
that referenced
this pull request
Jan 11, 2024
…3844) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Signed-off-by: Prabhas Kurapati <prabhask@berkeley.edu>
dlin2028
pushed a commit
to dlin2028/security
that referenced
this pull request
May 1, 2024
…3844) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates developer guide to reflect changes in demo config installation tool and removes integtest.sh as it is no longer used: opensearch-project/opensearch-build#497
Issues Resolved
Check List
New functionality includes testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.