Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getProperty.org.bouncycastle.pkcs12.default to plugin-security.policy #4265

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Apr 18, 2024

Description

Fixes issue related to bouncycastle upgrade where starting up a node with security plugin installed resulted in:

Caused by: java.lang.InternalError: cannot create instance of org.bouncycastle.jcajce.provider.keystore.PKCS12$Mappings : java.security.AccessControlException: access denied ("java.security.SecurityPermission" "getProperty.org.bouncycastle.pkcs12.default")
	at org.bouncycastle.jce.provider.BouncyCastleProvider.loadServiceClass(Unknown Source) ~[?:?]
	at org.bouncycastle.jce.provider.BouncyCastleProvider.loadAlgorithms(Unknown Source) ~[?:?]
        ...
  • Category

Maintenance

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…licy

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@reta
Copy link
Collaborator

reta commented Apr 18, 2024

Thanks @cwperks !

@cwperks
Copy link
Member Author

cwperks commented Apr 18, 2024

@reta Opened a backport to 2.x as well: #4266

This needs to go into 2.x first for the bwc tests to work.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.03%. Comparing base (0bfe765) to head (8e12d71).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4265      +/-   ##
==========================================
- Coverage   66.05%   66.03%   -0.02%     
==========================================
  Files         301      301              
  Lines       21711    21711              
  Branches     3506     3506              
==========================================
- Hits        14341    14337       -4     
- Misses       5608     5612       +4     
  Partials     1762     1762              

see 2 files with indirect coverage changes

@willyborankin willyborankin removed the backport 2.x backport to 2.x branch label Apr 18, 2024
@willyborankin willyborankin merged commit 9a85f23 into opensearch-project:main Apr 18, 2024
83 checks passed
dlin2028 pushed a commit to dlin2028/security that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants