-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracted the user attr handling methods from ConfigModelV7 into its own class #4416
Extracted the user attr handling methods from ConfigModelV7 into its own class #4416
Conversation
…own class Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4416 +/- ##
==========================================
+ Coverage 65.42% 65.45% +0.02%
==========================================
Files 310 311 +1
Lines 22013 22014 +1
Branches 3556 3556
==========================================
+ Hits 14402 14409 +7
+ Misses 5841 5836 -5
+ Partials 1770 1769 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I also like the idea of breaking #4380 down into such PRs to make the review faster. Feel free to raise such incremental PRs :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a refactor, let's just move in place.
@shikharj05 - want to make a follow up PR for some of those items you called out.
Description
This code change is just in preparation for the change in #4380 as requested in #4380 (comment) .
The code for user attribute handling is moved from the class ConfigModelV7 into its own class, as other new code will need to use it. Additionally, it enhances the structuring of the code by moving code with a specific purpose into its own class.
Personal note: A thorough re-design of this code might be worthwhile.
Issues Resolved
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.