-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DelegatingRestHandlerTests #4434
Conversation
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Come up in #4432 (comment) , thanks to @nibix |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4434 +/- ##
==========================================
+ Coverage 65.42% 65.44% +0.02%
==========================================
Files 310 312 +2
Lines 22013 22042 +29
Branches 3556 3559 +3
==========================================
+ Hits 14401 14426 +25
- Misses 5841 5843 +2
- Partials 1771 1773 +2
|
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 8c722f6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
What do you think about moving the delegating handler into core so this is avoided in future iterations? |
@peternied core has nothing to do with this change: in core the change is non-breaking and adds default method to |
Description
Fix DelegatingRestHandlerTests
Issues Resolved
Caused by opensearch-project/OpenSearch#13772
Is this a backport? If so, please add backport PR # and/or commits #
Testing
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.