Fix issue with Get mappings on a Closed index #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
DarshitChanpura,
nibix,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4685 +/- ##
==========================================
- Coverage 67.98% 67.97% -0.01%
==========================================
Files 310 310
Lines 20924 20924
Branches 3318 3319 +1
==========================================
- Hits 14225 14224 -1
Misses 4951 4951
- Partials 1748 1749 +1
|
shikharj05
approved these changes
Aug 28, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
stephen-crawford
previously approved these changes
Aug 28, 2024
RyanL1997
previously approved these changes
Aug 29, 2024
cwperks
commented
Aug 29, 2024
src/main/java/org/opensearch/security/securityconf/ConfigModelV6.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
dismissed stale reviews from RyanL1997 and stephen-crawford
via
7de38e5
shikharj05
reviewed
Sep 2, 2024
src/main/java/org/opensearch/security/identity/NoopPluginSubject.java
Outdated
Show resolved
Hide resolved
shikharj05
reviewed
Sep 2, 2024
src/main/java/org/opensearch/security/OpenSearchSecurityPlugin.java
Outdated
Show resolved
Hide resolved
shikharj05
suggested changes
Sep 2, 2024
Done |
|
Pushed another commit to resolve conflicts |
DarshitChanpura
approved these changes
Oct 2, 2024
|
@nibix @peternied @RyanL1997 @willyborankin Can I get another review on this? |
willyborankin
approved these changes
Oct 4, 2024
|
@cwperks LGTM |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 99457b1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue filtering out fields on a GET Mappings request on a closed index. This PR updates the indices options used when getting concrete indices.
Bug fix
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.