changing comments permission for alerting_ack_alerts role #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Toepker <toepkerd@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4709 +/- ##
=======================================
Coverage 65.22% 65.23%
=======================================
Files 318 318
Lines 22327 22327
Branches 3591 3591
=======================================
+ Hits 14562 14564 +2
+ Misses 5968 5964 -4
- Partials 1797 1799 +2 |
toepkerd
requested review from
cwperks,
DarshitChanpura,
nibix,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
shikharj05
reviewed
Sep 5, 2024
|
@toepkerd could you please address @shikharj05's comments? |
cwperks
approved these changes
Sep 9, 2024
cwperks
added
backport 2.x
RyanL1997
approved these changes
Sep 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Dennis Toepker <toepkerd@amazon.com> Co-authored-by: Dennis Toepker <toepkerd@amazon.com> (cherry picked from commit f9107b8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Dennis Toepker <toepkerd@amazon.com> Co-authored-by: Dennis Toepker <toepkerd@amazon.com> (cherry picked from commit f9107b8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Sep 9, 2024
tmanninger
pushed a commit
to tmanninger/opensearch-security
that referenced
this pull request
Sep 24, 2024
…-project#4709) Signed-off-by: Dennis Toepker <toepkerd@amazon.com> Co-authored-by: Dennis Toepker <toepkerd@amazon.com> Signed-off-by: tmanninger <t.manninger@ixolit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifying the alerting ack alerts role to give full access to comments, as opposed to only access to view comments.
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failedlabel from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.