-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where admin can read system index #4774
Merged
cwperks
merged 3 commits into
opensearch-project:main
from
derek-ho:fix-read-system-index
Oct 3, 2024
Merged
Fix bug where admin can read system index #4774
cwperks
merged 3 commits into
opensearch-project:main
from
derek-ho:fix-read-system-index
Oct 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
cwperks,
DarshitChanpura,
nibix,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
October 3, 2024 17:09
derek-ho
commented
Oct 3, 2024
cwperks
reviewed
Oct 3, 2024
src/main/java/org/opensearch/security/configuration/SecurityIndexSearcherWrapper.java
Show resolved
Hide resolved
cwperks
reviewed
Oct 3, 2024
src/integrationTest/java/org/opensearch/security/SystemIndexTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
force-pushed
the
fix-read-system-index
branch
from
October 3, 2024 18:52
a7458bd
to
7402adb
Compare
Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4774 +/- ##
==========================================
- Coverage 67.98% 67.96% -0.02%
==========================================
Files 310 310
Lines 20924 20926 +2
Branches 3318 3321 +3
==========================================
- Hits 14225 14223 -2
+ Misses 4951 4950 -1
- Partials 1748 1753 +5
|
willyborankin
approved these changes
Oct 3, 2024
cwperks
approved these changes
Oct 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 5cb4dd2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
5 tasks
derek-ho
added a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents reads on security system index registered through core
Issues Resolved
Fix: #4755
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failed
label from the original PR.No
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
No
Testing
Added unit test
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.