Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in HashingStoredFieldVisitor with stored fields #4826

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 21, 2024

Description

This PR fixes a bug inside HashingStoredFieldVisitor to account for stored_fields which are stored separately from _source in the backing index. This PR also adds integ tests to verify the correct behavior.

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Bug fix

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.89%. Comparing base (703d40f) to head (c4722a4).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...security/configuration/DlsFlsFilterLeafReader.java 50.00% 1 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4826      +/-   ##
==========================================
- Coverage   70.99%   70.89%   -0.10%     
==========================================
  Files         310      310              
  Lines       20938    20946       +8     
  Branches     3326     3331       +5     
==========================================
- Hits        14865    14850      -15     
- Misses       4325     4344      +19     
- Partials     1748     1752       +4     
Files with missing lines Coverage Δ
...security/configuration/DlsFlsFilterLeafReader.java 62.09% <50.00%> (-0.23%) ⬇️

... and 6 files with indirect coverage changes

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@willyborankin willyborankin added the backport 2.x backport to 2.x branch label Oct 21, 2024
@willyborankin willyborankin merged commit 8d7259d into opensearch-project:main Oct 21, 2024
41 of 43 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 8d7259d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nibix added a commit to nibix/security that referenced this pull request Oct 21, 2024
Signed-off-by: Nils Bandener <nils.bandener@eliatra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants