[2.12] excluding delete system index tests from a security enabled cluster #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
zhichao-aws
as code owners
owaiskazi19
changed the title
…d security files when security enabled Signed-off-by: Joshua Palis <jpalis@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.12 #222 +/- ##
=========================================
Coverage 81.55% 81.55%
Complexity 204 204
=========================================
Files 13 13
Lines 1052 1052
Branches 139 139
=========================================
Hits 858 858
Misses 140 140
Partials 54 54 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Joshua Palis <jpalis@amazon.com>
owaiskazi19
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
LGTM! Thanks @joshpalis. Can you forward port it to 2.x and main as well?
5 tasks
dhrubo-os
reviewed
Feb 9, 2024
dhrubo-os
reviewed
Feb 9, 2024
|
@dhrubo-os any concern before we merge this? |
no major concern. Let's just add the comment as it was also suggested by others. |
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
dhrubo-os
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Excludes integration test classes that attempt to delete system indices from running when security is enabled
Issues Resolved
Part of #189
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.