Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Improve IT framework to configure nodes on Test case level. #1816

Open
penghuo opened this issue Jul 7, 2023 · 2 comments
Open

[FEATURE] Improve IT framework to configure nodes on Test case level. #1816

penghuo opened this issue Jul 7, 2023 · 2 comments
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. maintenance Improves code quality, but not the product

Comments

@penghuo
Copy link
Collaborator

penghuo commented Jul 7, 2023 •
edited
Loading

Is your feature request related to a problem?
current RestTestIT does not support configure nodes for each test.
#1815

What solution would you like?
similar as https://github.com/opensearch-project/sql/blob/a816a58dc888d6596b6f4c174d1d03bdff3[…]src/test/java/org/opensearch/sql/correctness/CorrectnessIT.java

What alternatives have you considered?
configure nodes in build.gradle

Do you have any additional context?
Add any other context or screenshots about the feature request here.
@penghuo penghuo added enhancement New feature or request untriaged infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. and removed enhancement New feature or request untriaged labels Jul 7, 2023
@penghuo penghuo added maintenance Improves code quality, but not the product and removed untriaged labels Jul 7, 2023
@penghuo penghuo mentioned this issue Jul 7, 2023
Merged
6 tasks
@Yury-Fridlyand
Copy link
Collaborator

@penghuo please add more details. It is impossible to reduce number of nodes into a cluster.
IT framework creates cluster and then discovers test cases.
It is good enough for you to set 2-3-5 nodes into the default IT cluster for all tests?

@acarbonetto
Copy link
Collaborator

This can be closed, as changes for this IT test are being reverted #2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. maintenance Improves code quality, but not the product
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@penghuo @Yury-Fridlyand @acarbonetto