Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Guarantee datasource read api is strong consistent read (#1815)" #2013

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Aug 22, 2023

This reverts commit f38ffed.

Description

This change reverts the commit f38ffed as

  1. With Segment Replication - Support realtime reads with GET requests OpenSearch#8536, core now supports realtime reads with get/mget APIs. Thus, if strong reads are desired plugin can use get/mget queries. get/mget is recommended over _primary based routing preference in order to reduce load on primary.
  2. Existing OpenSearchDataSourceMetadataStorage.java uses match_all & term based search queries which does not provide strong reads and thus as part of Compatibility with segment replication #1801 there was no need to perform _primary based routing.

Issues Resolved

Relates: #1801

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…search-project#1815)"

This reverts commit f38ffed.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #2013 (9c17fcd) into main (b3fd4c4) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2013      +/-   ##
============================================
- Coverage     97.30%   97.30%   -0.01%     
  Complexity     4623     4623              
============================================
  Files           407      407              
  Lines         11935    11934       -1     
  Branches        828      828              
============================================
- Hits          11613    11612       -1     
  Misses          315      315              
  Partials          7        7              
Flag Coverage Δ
sql-engine 97.30% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/storage/OpenSearchDataSourceMetadataStorage.java 98.75% <ø> (-0.01%) ⬇️

Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for detailed description!

@MaxKsyunz MaxKsyunz merged commit 627189b into opensearch-project:main Aug 24, 2023
22 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 24, 2023
…" (#2013)

This reverts commit f38ffed.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit 627189b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon pushed a commit that referenced this pull request Sep 1, 2023
…" (#2013) (#2031)

This reverts commit f38ffed.


(cherry picked from commit 627189b)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants