Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the legacy SQL/PPL Setting #58

Closed
penghuo opened this issue May 17, 2021 · 0 comments · Fixed by #77, #76 or #70
Closed

Disable the legacy SQL/PPL Setting #58

penghuo opened this issue May 17, 2021 · 0 comments · Fixed by #77, #76 or #70
Assignees
Labels
enhancement New feature or request

Comments

@penghuo
Copy link
Collaborator

penghuo commented May 17, 2021

1.1 Descriptions
The following SQL plugin settings may be deprecated:

1.2 Proposal & Impacts

  • [A] Enable and remove the setting: Users cannot disable new engine: should be fine because new engine is already turned on in ODFE 1.13.
  • [B] Disable and remove all the settings: No semantic check when queries fall back.
  • [C] Make JDBC default and remove the setting: This was added long time ago when default response format switched from JSON to JDBC (table). Should be fine to remove this directly.

Open question: Should JSON formatter be deprecated? Currently queries are handled by old engine if format=json present. This may confuse users if the old engine behaves different due to missing feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant