Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove opensearch.sql.query.analysis.* related settings #76

Merged
merged 11 commits into from
May 20, 2021

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented May 20, 2021

Description

  1. Remove the following settings
  2. Default to the following value.
  • opensearch.sql.query.analysis.enabled: false
  • opensearch.sql.query.analysis.semantic.suggestion: false
  • opensearch.sql.query.analysis.semantic.threshold: 200

Issues Resolved

#58

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

penghuo added 11 commits May 18, 2021 19:35
Signed-off-by: penghuo <penghuo@gmail.com>
Signed-off-by: penghuo <penghuo@gmail.com>
Signed-off-by: penghuo <penghuo@gmail.com>
Signed-off-by: penghuo <penghuo@gmail.com>
Signed-off-by: penghuo <penghuo@gmail.com>
@penghuo penghuo requested review from dai-chen and chloe-zh May 20, 2021 00:08
@penghuo penghuo self-assigned this May 20, 2021
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@penghuo penghuo merged commit 0b0b551 into opensearch-project:develop May 20, 2021
@penghuo penghuo deleted the pr-issue58 branch May 20, 2021 02:17
@penghuo penghuo linked an issue May 20, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable the legacy SQL/PPL Setting
3 participants