Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI for windows #1140

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Dec 6, 2022

Signed-off-by: Peng Huo penghuo@gmail.com

Description

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo requested a review from a team as a code owner December 6, 2022 03:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #1140 (1da3904) into 1.x (4a15c2f) will increase coverage by 32.33%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                1.x    #1140       +/-   ##
=============================================
+ Coverage     62.91%   95.25%   +32.33%     
- Complexity        0     2746     +2746     
=============================================
  Files            10      276      +266     
  Lines           658     7416     +6758     
  Branches        119      546      +427     
=============================================
+ Hits            414     7064     +6650     
- Misses          191      298      +107     
- Partials         53       54        +1     
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine 98.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../org/opensearch/sql/sql/antlr/SQLSyntaxParser.java 100.00% <0.00%> (ø)
...earch/storage/script/filter/lucene/RangeQuery.java 100.00% <0.00%> (ø)
...nsearch/executor/protector/ExecutionProtector.java 100.00% <0.00%> (ø)
.../org/opensearch/sql/data/model/ExprShortValue.java 100.00% <0.00%> (ø)
...rch/planner/logical/rule/MergeSortAndIndexAgg.java 100.00% <0.00%> (ø)
...pensearch/sql/planner/physical/WindowOperator.java 100.00% <0.00%> (ø)
...java/org/opensearch/sql/sql/parser/AstBuilder.java 100.00% <0.00%> (ø)
...opensearch/sql/planner/logical/LogicalPlanDSL.java 100.00% <0.00%> (ø)
...ch/sql/planner/optimizer/LogicalPlanOptimizer.java 100.00% <0.00%> (ø)
.../opensearch/sql/planner/logical/LogicalRemove.java 100.00% <0.00%> (ø)
... and 256 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Signed-off-by: Peng Huo <penghuo@gmail.com>
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@penghuo penghuo merged commit 62a6c1f into opensearch-project:1.x Dec 6, 2022
@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants