Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring datasource changes to a new module. #1504

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

vamsi-amazon
Copy link
Member

@vamsi-amazon vamsi-amazon commented Apr 7, 2023

Description

  • Refactoring datasource changes to new module.
  • will write test cases for RestClass in next PR.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Merging #1504 (b28bd30) into main (3fbbaa4) will decrease coverage by 1.39%.
The diff coverage is 64.00%.

❗ Current head b28bd30 differs from pull request most recent head a1e11ec. Consider uploading reports for the commit a1e11ec to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #1504      +/-   ##
============================================
- Coverage     98.47%   97.09%   -1.39%     
- Complexity     3886     3970      +84     
============================================
  Files           347      368      +21     
  Lines          9649    10123     +474     
  Branches        625      651      +26     
============================================
+ Hits           9502     9829     +327     
- Misses          142      287     +145     
- Partials          5        7       +2     
Flag Coverage Δ
sql-engine 97.09% <64.00%> (-1.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...earch/sql/datasources/auth/AuthenticationType.java 100.00% <ø> (ø)
...ources/exceptions/DataSourceNotFoundException.java 100.00% <ø> (ø)
...earch/sql/datasources/exceptions/ErrorMessage.java 0.00% <0.00%> (ø)
...model/transport/CreateDataSourceActionRequest.java 27.27% <ø> (ø)
...odel/transport/CreateDataSourceActionResponse.java 0.00% <ø> (ø)
...model/transport/DeleteDataSourceActionRequest.java 18.75% <ø> (ø)
...odel/transport/DeleteDataSourceActionResponse.java 0.00% <ø> (ø)
...es/model/transport/GetDataSourceActionRequest.java 27.27% <ø> (ø)
...s/model/transport/GetDataSourceActionResponse.java 0.00% <ø> (ø)
...model/transport/UpdateDataSourceActionRequest.java 27.27% <ø> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YANG-DB
Copy link
Member

YANG-DB commented Apr 7, 2023

This is an excellent addition to create the datasource module !!
Can you please add a README.md file in that root of the new module ?

YANG-DB
YANG-DB previously approved these changes Apr 7, 2023
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
@vamsi-amazon vamsi-amazon merged commit 7584f79 into opensearch-project:main Apr 10, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2023
* Reafactor into new datasources module

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* Refactored all the datasource releated code to new datasources module

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* More unit tests

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

---------

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit 7584f79)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2023
* Reafactor into new datasources module

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* Refactored all the datasource releated code to new datasources module

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* More unit tests

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

---------

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit 7584f79)
@dai-chen dai-chen added the maintenance Improves code quality, but not the product label Apr 11, 2023
vamsi-amazon added a commit that referenced this pull request Apr 14, 2023
* Reafactor into new datasources module

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* Refactored all the datasource releated code to new datasources module

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* More unit tests

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

---------

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit 7584f79)

Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
vamsi-amazon added a commit that referenced this pull request Apr 14, 2023
* Reafactor into new datasources module

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* Refactored all the datasource releated code to new datasources module

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* More unit tests

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

---------

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
(cherry picked from commit 7584f79)

Co-authored-by: Vamsi Manohar <reddyvam@amazon.com>
acarbonetto pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Apr 18, 2023
)

* Reafactor into new datasources module

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* Refactored all the datasource releated code to new datasources module

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

* More unit tests

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>

---------

Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.7 maintenance Improves code quality, but not the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datasource APIS] Documentation and other miscellaneous tasks
7 participants