Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.json dependency version (#1586) #1598

Merged

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented May 1, 2023

Description

Cherry pick #1586 because auto backport PR failed.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Bump org.json version for CVE

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix assertion by json array similar method

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix more assertions which failed on query path return BigDecimal

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix legacy expr value factory

Signed-off-by: Chen Dai <daichen@amazon.com>

---------

Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen added dependencies Pull requests that update a dependency file backport 2.x labels May 1, 2023
@dai-chen dai-chen self-assigned this May 1, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1598 (36fa428) into main (3fc11a4) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1598   +/-   ##
=========================================
  Coverage     97.16%   97.16%           
  Complexity     4116     4116           
=========================================
  Files           371      371           
  Lines         10366    10366           
  Branches        704      704           
=========================================
  Hits          10072    10072           
  Misses          287      287           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dai-chen
Copy link
Collaborator Author

dai-chen commented May 2, 2023

Only BWC test failed.

@Yury-Fridlyand Yury-Fridlyand merged commit ff2050d into opensearch-project:main May 3, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 3, 2023
* Bump org.json version for CVE

* Fix assertion by json array similar method

* Fix more assertions which failed on query path return BigDecimal

* Fix legacy expr value factory

---------

Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit ff2050d)
dai-chen added a commit that referenced this pull request May 5, 2023
* Bump org.json version for CVE

* Fix assertion by json array similar method

* Fix more assertions which failed on query path return BigDecimal

* Fix legacy expr value factory

---------

Signed-off-by: Chen Dai <daichen@amazon.com>
(cherry picked from commit ff2050d)

Co-authored-by: Chen Dai <daichen@amazon.com>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jun 12, 2023
…h-project#1598)

* Bump org.json version for CVE

* Fix assertion by json array similar method

* Fix more assertions which failed on query path return BigDecimal

* Fix legacy expr value factory

---------

Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants