Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workbench and its workflows #1608

Merged

Conversation

kavithacm
Copy link
Collaborator

Description

Removing workbench and its workflows from SQL repository 1.3 branch to reduce unwanted CVE advisories for this branch

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
derek-ho
derek-ho previously approved these changes May 4, 2023
@YANG-DB
Copy link
Member

YANG-DB commented May 4, 2023

please fix the links in the README.md file pointing to the deleted folder

Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix links from README.md pointing to deleted files

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@dai-chen
Copy link
Collaborator

dai-chen commented May 5, 2023

Does this mean all future SQL Workbench release should happen in the new repo? If so, should we remove it from all ?.x branch? Same for other clients code?

@kavithacm
Copy link
Collaborator Author

This change is only required for 1.3 branch workbench as it has CVEs, future releases for 1.3 branch should be done in new repo for workbench.

@dai-chen
Copy link
Collaborator

dai-chen commented May 8, 2023

This change is only required for 1.3 branch workbench as it has CVEs, future releases for 1.3 branch should be done in new repo for workbench.

Does Workbench code in 1.x branch have the fix? If not, I think we should remove at least 1.x along with 1.3. Otherwise, future branch 1.4, 1.5 will have same CVE?

@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label May 8, 2023
@kavithacm
Copy link
Collaborator Author

This change is only required for 1.3 branch workbench as it has CVEs, future releases for 1.3 branch should be done in new repo for workbench.

Does Workbench code in 1.x branch have the fix? If not, I think we should remove at least 1.x along with 1.3. Otherwise, future branch 1.4, 1.5 will have same CVE?

I agree, if 1.x doesn't have the CVE fix, we should remove it there too. Currently we're focusing on 1.3 branch as there's a release this week

@pjfitzgibbons pjfitzgibbons merged commit c2cd527 into opensearch-project:1.3 May 8, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants