Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query rewrite for partition skipping index #1690

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented May 31, 2023

Description

  1. Remove "provided" qualifier on org.json4s.native because I found it's not built in Spark distribution during local test: other json4s library like json4s.core, jackson are present. I will check if we can use them instead.
  2. Add FlintSparkOptimizer which has only skipping index query rewrite rule ApplyFlintSparkSkippingIndex
  3. Add Flint optimizer rule config spark.flint.optimizer.enabled so query rewrite can be disabled in IT as needed

TODO:

  1. Finalize what should be columnType and outputSchema in FlintSparkSkippingStrategy and whether it needs to be stored in Flint metadata
  2. Support different source table in query rewrite rule

Issues Resolved

opensearch-project/opensearch-spark#2

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #1690 (db4e44b) into feature/flint (e80cf9b) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             feature/flint    opensearch-project/sql#1690   +/-   ##
================================================
  Coverage            97.19%   97.19%           
  Complexity            4107     4107           
================================================
  Files                  371      371           
  Lines                10464    10464           
  Branches               706      706           
================================================
  Hits                 10170    10170           
  Misses                 287      287           
  Partials                 7        7           
Flag Coverage Δ
sql-engine 97.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen marked this pull request as ready for review June 2, 2023 21:56
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen requested a review from penghuo June 5, 2023 18:25
@dai-chen dai-chen merged commit 35d5813 into opensearch-project:feature/flint Jun 5, 2023
@dai-chen dai-chen deleted the add-partition-index-query-rewrite-2 branch June 5, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Flint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants