Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance flint spark configuration #1727

Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Jun 8, 2023

Description

improve the FlintSparkConf to support the following use cases.

  • storage options, user provide options in DF
    • write.refresh_policy
  • flint spark configuration, user set using spark.conf.set(). there are two set of configs
    • spark.flint.xxx.yyy, for example, spark.flint.optimizer.enabled
    • spark.datasource.flint.xxx.yyy , for example, spark.datasource.flint.write.refresh_policy
  • sql configuration, generic configuration defined by spark
    • spark.sql.session.timeZone

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo added enhancement New feature or request Flint labels Jun 8, 2023
@penghuo penghuo self-assigned this Jun 8, 2023
@penghuo penghuo changed the title enhance flint spark configuration module enhance flint spark configuration Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #1727 (6b9a07d) into feature/flint (e80cf9b) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             feature/flint    #1727   +/-   ##
================================================
  Coverage            97.19%   97.19%           
  Complexity            4107     4107           
================================================
  Files                  371      371           
  Lines                10464    10464           
  Branches               706      706           
================================================
  Hits                 10170    10170           
  Misses                 287      287           
  Partials                 7        7           
Flag Coverage Δ
sql-engine 97.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactoring!

@penghuo penghuo merged commit 255f040 into opensearch-project:feature/flint Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Flint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants