Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore id column #1732

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Jun 12, 2023

Description

  1. by default, id column will be ignored when write to flint storage.
  2. user could set spark.datasource.flint.ignore.id_column = false to include id column.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo changed the title Flint docid pr ignore id column Jun 12, 2023
@penghuo penghuo added the Flint label Jun 12, 2023
@penghuo penghuo self-assigned this Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1732 (27ecd64) into feature/flint (e80cf9b) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             feature/flint    #1732   +/-   ##
================================================
  Coverage            97.19%   97.19%           
  Complexity            4107     4107           
================================================
  Files                  371      371           
  Lines                10464    10464           
  Branches               706      706           
================================================
  Hits                 10170    10170           
  Misses                 287      287           
  Partials                 7        7           
Flag Coverage Δ
sql-engine 97.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Peng Huo <penghuo@gmail.com>
@penghuo penghuo requested a review from dai-chen June 19, 2023 15:09
@penghuo penghuo marked this pull request as ready for review June 19, 2023 15:09
@dai-chen dai-chen merged commit 102c8c8 into opensearch-project:feature/flint Jun 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants