[Backport 2.x] Support user-defined and incomplete date formats (#273) #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Support user-defined and incomplete date formats (#273) * Check custom formats for characters Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Removed duplicated code Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Reworked checking for exprcoretype Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Changed check for time Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> * Rework processing custom and incomplete formats and add tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Values of incomplete and incorrect formats to be returned as `TIMESTAMP` instead of `STRING`. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Complete fix and update tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * More fixes for god of fixes. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Refactoring. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Guian Gumpac <guian.gumpac@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Guian Gumpac <guian.gumpac@improving.com> (cherry picked from commit a60b222)
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #1830 +/- ##
=========================================
Coverage 97.35% 97.36%
- Complexity 4443 4473 +30
=========================================
Files 388 388
Lines 10998 11036 +38
Branches 784 798 +14
=========================================
+ Hits 10707 10745 +38
Misses 284 284
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
MaxKsyunz
approved these changes
Jul 11, 2023
forestmvey
approved these changes
Jul 11, 2023
GumpacG
approved these changes
Jul 11, 2023
Yury-Fridlyand
approved these changes
Jul 11, 2023
matthewryanwells
approved these changes
Jul 11, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a60b222 from #1821