Statically init typeActionMap in OpenSearchExprValueFactory.
#1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1897 +/- ##
============================================
- Coverage 97.39% 97.39% -0.01%
+ Complexity 4608 4603 -5
============================================
Files 401 401
Lines 11408 11397 -11
Branches 843 835 -8
============================================
- Hits 11111 11100 -11
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matthewryanwells
approved these changes
Jul 24, 2023
GumpacG
approved these changes
Jul 25, 2023
MaxKsyunz
approved these changes
Jul 26, 2023
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 27, 2023
…y`. (#310) (opensearch-project#1897)" This reverts commit c8d42a7.
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 27, 2023
… (opensearch-project#1897) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Added support of timestamp/date/time using curly brackets (opensearch-project#1894) * Added support of timestamp/date/time using curly brackets (#297) * added bracketed time/date/timestamp input, tests, and documentation Signed-off-by: Matthew Wells <matthew.wells@improving.com> * improved failing tests Signed-off-by: Matthew Wells <matthew.wells@improving.com> * simplified tests for checking for failure Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed redundant tests and improved tests that should fail Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> Bump bwc version (opensearch-project#1876) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Prometheus Query Exemplars (opensearch-project#1782) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Adding google code changes for core/src/main/java/org/opensearch/sql/analysis core/src/main/java/org/opensearch/sql/ast core/src/main/java/org/opensearch/sql/data core/src/main/java/org/opensearch/sql/datasource Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Disable checkstyle fore core module and enable spotless check for the files being checked. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Added back core checkstyle test in sql-test-workflow.yml Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Revert "Prometheus Query Exemplars (opensearch-project#1782)" This reverts commit 430d7a9. Revert "Bump bwc version (opensearch-project#1876)" This reverts commit 501392e. Revert "Added support of timestamp/date/time using curly brackets (opensearch-project#1894)" This reverts commit 1a7134b. Revert "Statically init `typeActionMap` in `OpenSearchExprValueFactory`. (#310) (opensearch-project#1897)" This reverts commit c8d42a7. Revert "Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (opensearch-project#1899)" This reverts commit 7b932a7.
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 28, 2023
… (opensearch-project#1897) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Added support of timestamp/date/time using curly brackets (opensearch-project#1894) * Added support of timestamp/date/time using curly brackets (#297) * added bracketed time/date/timestamp input, tests, and documentation Signed-off-by: Matthew Wells <matthew.wells@improving.com> * improved failing tests Signed-off-by: Matthew Wells <matthew.wells@improving.com> * simplified tests for checking for failure Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed redundant tests and improved tests that should fail Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> Bump bwc version (opensearch-project#1876) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Prometheus Query Exemplars (opensearch-project#1782) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Adding google code changes for core/src/main/java/org/opensearch/sql/analysis core/src/main/java/org/opensearch/sql/ast core/src/main/java/org/opensearch/sql/data core/src/main/java/org/opensearch/sql/datasource Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Disable checkstyle fore core module and enable spotless check for the files being checked. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Added back core checkstyle test in sql-test-workflow.yml Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Revert "Prometheus Query Exemplars (opensearch-project#1782)" This reverts commit 430d7a9. Revert "Bump bwc version (opensearch-project#1876)" This reverts commit 501392e. Revert "Added support of timestamp/date/time using curly brackets (opensearch-project#1894)" This reverts commit 1a7134b. Revert "Statically init `typeActionMap` in `OpenSearchExprValueFactory`. (#310) (opensearch-project#1897)" This reverts commit c8d42a7. Revert "Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (opensearch-project#1899)" This reverts commit 7b932a7. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 28, 2023
… (opensearch-project#1897) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 28, 2023
… (opensearch-project#1897) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jul 31, 2023
… (opensearch-project#1897) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Added support of timestamp/date/time using curly brackets (opensearch-project#1894) * Added support of timestamp/date/time using curly brackets (#297) * added bracketed time/date/timestamp input, tests, and documentation Signed-off-by: Matthew Wells <matthew.wells@improving.com> * improved failing tests Signed-off-by: Matthew Wells <matthew.wells@improving.com> * simplified tests for checking for failure Signed-off-by: Matthew Wells <matthew.wells@improving.com> * fixed redundant tests and improved tests that should fail Signed-off-by: Matthew Wells <matthew.wells@improving.com> --------- Signed-off-by: Matthew Wells <matthew.wells@improving.com> Bump bwc version (opensearch-project#1876) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Prometheus Query Exemplars (opensearch-project#1782) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Adding google code changes for core/src/main/java/org/opensearch/sql/analysis core/src/main/java/org/opensearch/sql/ast core/src/main/java/org/opensearch/sql/data core/src/main/java/org/opensearch/sql/datasource Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Disable checkstyle fore core module and enable spotless check for the files being checked. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Added back core checkstyle test in sql-test-workflow.yml Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Revert "Prometheus Query Exemplars (opensearch-project#1782)" This reverts commit 430d7a9. Revert "Bump bwc version (opensearch-project#1876)" This reverts commit 501392e. Revert "Added support of timestamp/date/time using curly brackets (opensearch-project#1894)" This reverts commit 1a7134b. Revert "Statically init `typeActionMap` in `OpenSearchExprValueFactory`. (#310) (opensearch-project#1897)" This reverts commit c8d42a7. Revert "Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (opensearch-project#1899)" This reverts commit 7b932a7. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpenSearchExprValueFactorycreated for every query for every index and it creates a constanttypeActionMapevery time from the scratch.Current fix makes
typeActionMapinitiated statically, so it will be created only once. This slightly increases query processing performance.Issues Resolved
Performance boost.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.