[Spotless] Applying Google Code Format for core #5 #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding core final GJF fix. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Codecov Report
@@ Coverage Diff @@
## main #1951 +/- ##
=========================================
Coverage 97.51% 97.51%
Complexity 4657 4657
=========================================
Files 408 408
Lines 11930 11931 +1
Branches 830 830
=========================================
+ Hits 11633 11634 +1
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
6 tasks
Yury-Fridlyand
previously approved these changes
Aug 10, 2023
|
Please, fix CI |
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
GumpacG
approved these changes
Aug 10, 2023
Yury-Fridlyand
approved these changes
Aug 10, 2023
Yury-Fridlyand
merged commit 91bbb5d
into
opensearch-project:main
13 of 15 checks passed
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 14, 2023
…t#1951) * Integ/sl google java format5 (#332) Adding core final GJF fix. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * remove repeated unused checkstyle. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * replaced nbsp with pre tag. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Add test fixtures to failure ignore in core build.gradle. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 18, 2023
…t#1951) * Integ/sl google java format5 (#332) Adding core final GJF fix. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * remove repeated unused checkstyle. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * replaced nbsp with pre tag. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Add test fixtures to failure ignore in core build.gradle. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Aug 22, 2023
) (#1996) * spotlesss apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * fixed target for spotless Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * fixed comments of spotless Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based off #1930, #1931. #1932. #1933 and applies spotless to entire
coreproject. Covers remaining fixes not covered by PR 1-4.Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.