[Spotless] Applying Google Code Format for integ-tests #8 #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ignore failures for build.gradle. Reverting ignore for checkstyle in integ-test Addressed PR comments. Addressed PR comments to expand jav doc. fixed string formatting Fixed string formatting. Fixed string formatting in MatchPhrasePrefixIT Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1962 +/- ##
============================================
- Coverage 97.51% 97.51% -0.01%
+ Complexity 4657 4656 -1
============================================
Files 408 408
Lines 11933 11930 -3
Branches 829 829
============================================
- Hits 11637 11634 -3
Misses 289 289
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
integ-test/src/test/java/org/opensearch/sql/correctness/runner/resultset/DBResult.java
Outdated
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/correctness/runner/resultset/DBResult.java
Outdated
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/legacy/CursorIT.java
Outdated
Show resolved
Hide resolved
integ-test/src/test/java/org/opensearch/sql/legacy/JSONRequestIT.java
Outdated
Show resolved
Hide resolved
| @@ -5,15 +5,16 @@ | |||
|
|
|||
| package org.opensearch.sql.sql; | |||
|
|
|||
| import org.junit.Test; | |||
There was a problem hiding this comment.
import order is incorrect
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Yury-Fridlyand
previously approved these changes
Aug 15, 2023
GumpacG
reviewed
Aug 15, 2023
| var query = String.format("SELECT * FROM %s", table); | ||
| ResultSet rs = stmt.executeQuery(query); | ||
| int rows = 0; | ||
| for (; rs.next(); rows++) ; | ||
| for (; rs.next(); rows++) |
There was a problem hiding this comment.
NIT: Maybe switch this to a while loop. Looks odd to have ; on a separate column.
GumpacG
previously approved these changes
Aug 15, 2023
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
MitchellGale
dismissed stale reviews from GumpacG and Yury-Fridlyand
via
5eb9b87
acarbonetto
approved these changes
Aug 16, 2023
Yury-Fridlyand
approved these changes
Aug 16, 2023
Yury-Fridlyand
merged commit c60a4f1
into
opensearch-project:main
14 of 15 checks passed
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 22, 2023
…-project#1962) * spotless apply for 81 integ-test files (#327) add ignore failures for build.gradle. Reverting ignore for checkstyle in integ-test Addressed PR comments. Addressed PR comments to expand jav doc. fixed string formatting Fixed string formatting. Fixed string formatting in MatchPhrasePrefixIT Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Apply suggestions from code review Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * address PR comments Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spotless apply on integ-test (part 1 of 4 integ-test integration).
Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.