Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource description #2132

Merged

Conversation

vamsi-amazon
Copy link
Member

Description

  • Added description field to datasource metadata.
  • Removed restriction on all fields with prefix auth. Now only username, password, access_key, secret_key are the only fields removed from GET datasource API.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
@vamsi-amazon vamsi-amazon self-assigned this Sep 22, 2023
@vamsi-amazon vamsi-amazon added backport 2.x enhancement New feature or request labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2132 (34f5a11) into main (61d1eb7) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2132   +/-   ##
=========================================
  Coverage     97.27%   97.27%           
- Complexity     4623     4624    +1     
=========================================
  Files           410      410           
  Lines         11947    11951    +4     
  Branches        828      828           
=========================================
+ Hits          11621    11625    +4     
  Misses          317      317           
  Partials          9        9           
Flag Coverage Δ
sql-engine 97.27% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rch/sql/datasources/utils/XContentParserUtils.java 100.00% <100.00%> (ø)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM quick question for my learning

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm the BWC, old data source metadata can still be handled by this new code?

@vamsi-amazon
Copy link
Member Author

Just to confirm the BWC, old data source metadata can still be handled by this new code?

Yes it can handle, BWC is because of different issue.

@vamsi-amazon vamsi-amazon merged commit 7bad8f9 into opensearch-project:main Sep 22, 2023
19 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 22, 2023
* Fix mockito core

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Use mockito version from core

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

* Add datasource description

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>

---------

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit 7bad8f9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon pushed a commit that referenced this pull request Sep 22, 2023
* Fix mockito core



* Use mockito version from core



* Add datasource description



---------


(cherry picked from commit 7bad8f9)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants