Handle EMR Exceptions in FlintCancelJob Operation #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2577 +/- ##
=========================================
Coverage 95.36% 95.36%
- Complexity 5129 5131 +2
=========================================
Files 490 490
Lines 14419 14427 +8
Branches 966 968 +2
=========================================
+ Hits 13751 13759 +8
Misses 643 643
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vamsi-amazon
force-pushed
the
emr-exception
branch
2 times, most recently
from
a23a89e
to
1c49359
Compare
vamsi-amazon
commented
Mar 22, 2024
spark/src/main/java/org/opensearch/sql/spark/flint/operation/FlintIndexOp.java
Outdated
Show resolved
Hide resolved
vamsi-amazon
commented
Mar 22, 2024
spark/src/main/java/org/opensearch/sql/spark/flint/operation/FlintIndexOp.java
Show resolved
Hide resolved
vamsi-amazon
force-pushed
the
emr-exception
branch
from
1c49359
to
a3fe17b
Compare
vamsi-amazon
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
vamsi-amazon
force-pushed
the
emr-exception
branch
from
a3fe17b
to
e35d065
Compare
penghuo
previously approved these changes
Mar 22, 2024
vamsi-amazon
force-pushed
the
emr-exception
branch
3 times, most recently
from
cb2d455
to
4e9910e
Compare
vamsi-amazon
force-pushed
the
emr-exception
branch
3 times, most recently
from
3ad9827
to
f2047a5
Compare
vamsi-amazon
added
bug
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsi-amazon
force-pushed
the
emr-exception
branch
from
f2047a5
to
ae7b529
Compare
seankao-az
approved these changes
Mar 25, 2024
rupal-bq
approved these changes
Mar 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit bfcaedf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit bfcaedf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit bfcaedf) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon
pushed a commit
that referenced
this pull request
Mar 25, 2024
(cherry picked from commit bfcaedf) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles different kinds of exception from EMRServerless when cancelling a job. There are frequent scenarios where the streaming job is already in cancelled state and resulting in error of ALTER INDEX command. This PR catches scenarios where the job is already in cancelled state and proceeds with the command execution.
ResourceNotFoundException: When JobId is not present.
ValidationException: When JobRun is not in a cancellable state.
OtherExceptions.
Fixed Datasources IT.
Fixed Settings documentation: https://github.com/vamsi-amazon/sql/blob/emr-exception/docs/user/admin/settings.rst#pluginsqueryexecutionengineasync_queryenabled
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.