Removing old datasources model integ test and added unit test. #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamsi-amazon
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
YANG-DB
previously approved these changes
Mar 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
=========================================
Coverage 95.37% 95.37%
Complexity 5131 5131
=========================================
Files 490 490
Lines 14428 14428
Branches 968 968
=========================================
Hits 13760 13760
Misses 643 643
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
vamsi-amazon
changed the title
dai-chen
approved these changes
Mar 26, 2024
rupal-bq
approved these changes
Mar 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit e153609) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> (cherry picked from commit e153609) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon
pushed a commit
that referenced
this pull request
Mar 26, 2024
(cherry picked from commit e153609) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon
pushed a commit
that referenced
this pull request
Mar 26, 2024
(cherry picked from commit e153609) Signed-off-by: Vamsi Manohar <reddyvam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing old datasources model test as it is causing issues when running with security plugin. Load documents into system index requires superAdmin permissions and are not available while running integ tests against a rest cluster.
So introduced a unit test case which covers this usecase.
Issues Resolved
#2573
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.