Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old datasources model integ test and added unit test. #2594

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

vamsi-amazon
Copy link
Member

@vamsi-amazon vamsi-amazon commented Mar 26, 2024

Description

Removing old datasources model test as it is causing issues when running with security plugin. Load documents into system index requires superAdmin permissions and are not available while running integ tests against a rest cluster.
So introduced a unit test case which covers this usecase.

Issues Resolved

#2573

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

YANG-DB
YANG-DB previously approved these changes Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.37%. Comparing base (bfcaedf) to head (95b28d9).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2594   +/-   ##
=========================================
  Coverage     95.37%   95.37%           
  Complexity     5131     5131           
=========================================
  Files           490      490           
  Lines         14428    14428           
  Branches        968      968           
=========================================
  Hits          13760    13760           
  Misses          643      643           
  Partials         25       25           
Flag Coverage Δ
sql-engine 95.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
@vamsi-amazon vamsi-amazon changed the title Removing old datasources model test Removing old datasources model integ test and added unit test. Mar 26, 2024
@vamsi-amazon vamsi-amazon merged commit e153609 into opensearch-project:main Mar 26, 2024
24 of 28 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 26, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit e153609)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 26, 2024
Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
(cherry picked from commit e153609)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon pushed a commit that referenced this pull request Mar 26, 2024
(cherry picked from commit e153609)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsi-amazon pushed a commit that referenced this pull request Mar 26, 2024
(cherry picked from commit e153609)

Signed-off-by: Vamsi Manohar <reddyvam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Integration Test failed for sql: 2.13.0
4 participants