-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support complex predicates for IF
function in PPL
#2756
Support complex predicates for IF
function in PPL
#2756
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
None of current build issues caused by this PR. |
could u merge latest change from main and re-run test. |
Gently ping @penghuo @vamsi-amazon @YANG-DB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2756-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 593ffabbbdc6d6a9529ef3d6c233785e29fedb07
# Push it to GitHub
git push --set-upstream origin backport/backport-2756-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
…ect#2756) Signed-off-by: Lantao Jin <ltjin@amazon.com>
…ect#2756) Signed-off-by: Lantao Jin <ltjin@amazon.com>
Description
The predicate of function
if(predicate, arg1, arg2)
in PPL should support complex expression.The current implementation only supports
TrueLiteral
andFalseLiteral
, just like the example given in doc. Query such as|eval test=if(pgs > 2, "yes", "no")
will fail with"details": "Failed to parse query due to offending symbol [>] at:
This PR aims to support complex predicate expression, following cases will be supported:
Issues Resolved
Resolves #2600 and #2653
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.