Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Well format the raw response when query parameter "pretty" enabled #2829

Merged

Conversation

LantaoJin
Copy link
Member

Backport aec4825 from #2727

The backport by opensearch-trigger-bot failed with exit code 128 (Ref: #2727 (comment))

…pensearch-project#2727)

Signed-off-by: Lantao Jin <ltjin@amazon.com>
(cherry picked from commit aec4825)
@LantaoJin
Copy link
Member Author

The auto-backport process failed with The process '/usr/bin/git' failed with exit code 128, manually backport it. @penghuo @dai-chen @vamsi-amazon. Only MacOS Build failed.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (8856f85) to head (69d73ce).

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #2829      +/-   ##
============================================
+ Coverage     94.65%   94.66%   +0.01%     
- Complexity     5135     5180      +45     
============================================
  Files           509      511       +2     
  Lines         14600    14639      +39     
  Branches        946      944       -2     
============================================
+ Hits          13819    13858      +39     
  Misses          740      740              
  Partials         41       41              
Flag Coverage Δ
sql-engine 94.66% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LantaoJin
Copy link
Member Author

LantaoJin commented Jul 17, 2024

Security IT failed due to https://github.com/opensearch-project/security/actions/runs/9967076404/job/27540175842
Workflows are needed to rerun when above job succeed again.
But all these failures are not related to this PR. This manually backport still needs another approval from maintainers, cc @penghuo @vamsi-amazon, then I will merge it after all workflows passed.

@LantaoJin
Copy link
Member Author

Security ITs now passed with the help from opensearch-project/security#4576

@penghuo penghuo merged commit f7c1f09 into opensearch-project:2.x Jul 18, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants