Correct regular expression range #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
force-pushed
the
pr/code-scanning/8
branch
from
d2d83ef
to
4aa5375
Compare
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG and
ykmr1224
as code owners
YANG-DB
approved these changes
Jul 18, 2024
dai-chen
approved these changes
Jul 22, 2024
For backward compatibility, we can fix the security issue to add all characters: |
Got it. Feel free to merge. Thanks! |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
Signed-off-by: Lantao Jin <ltjin@amazon.com> (cherry picked from commit 7022a09) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs
pushed a commit
to manasvinibs/sql
that referenced
this pull request
Aug 14, 2024
Signed-off-by: Lantao Jin <ltjin@amazon.com>
jzonthemtn
pushed a commit
to jzonthemtn/sql
that referenced
this pull request
Aug 28, 2024
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regular expression
[A-z]also matches the characters:[ \ ] ^ _ `. It may have overly permissive range risk. Correct it with[a-zA-Z_].Issues Resolved
Resolves https://github.com/opensearch-project/sql/security/code-scanning/8
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.