Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SparkExecutionEngineConfigClusterSetting deserialize issue #2838

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Jul 17, 2024

Description

  • Fix SparkExecutionEngineConfigClusterSetting deserialize issue
  • GSON could use NoArgsConstructor / AllArgsConstructor when TypeAdapter is used to build GSON instance.
  • Fixed this back to default GSON since this class does not require custom handling.

Issues Resolved

n/a

Check List

  • [n/a] New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • [n/a] New functionality has been documented.
    • [n/a] New functionality has javadoc added
    • [n/a] New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224 ykmr1224 added bug Something isn't working backport 2.x labels Jul 17, 2024
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@ykmr1224 ykmr1224 added the v2.16.0 Issues targeting release v2.16.0 label Jul 23, 2024
@ykmr1224 ykmr1224 merged commit 2117650 into opensearch-project:main Jul 23, 2024
15 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 23, 2024
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
(cherry picked from commit 2117650)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 pushed a commit that referenced this pull request Jul 24, 2024
#2855)

(cherry picked from commit 2117650)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 24, 2024
#2855)

(cherry picked from commit 2117650)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 277f9e2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 pushed a commit that referenced this pull request Jul 24, 2024
#2855) (#2856)

(cherry picked from commit 2117650)




(cherry picked from commit 277f9e2)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ykmr1224 ykmr1224 deleted the fix-deserialize-issue branch July 30, 2024 20:57
manasvinibs pushed a commit to manasvinibs/sql that referenced this pull request Aug 14, 2024
jzonthemtn pushed a commit to jzonthemtn/sql that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working v2.16.0 Issues targeting release v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants