Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Update SqlBaseParser #2890

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Aug 1, 2024

Description

  • Update SqlBaseParser.g4 file to solve build issue.
  • The file was not valid and caused build issue in network disconnected environment.
  • This change will align the file to main branch.

Related Issues

n/a

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@dai-chen
Copy link
Collaborator

dai-chen commented Aug 1, 2024

I found that we probably should track Spark 3.3.2 and Flint 0.4 instead of main branch of both? cc: @vamsi-amazon

@vamsi-amazon
Copy link
Member

I found that we probably should track Spark 3.3.2 and Flint 0.4 instead of main branch of both? cc: @vamsi-amazon

+1

@ykmr1224 ykmr1224 merged commit d75af24 into opensearch-project:2.x Aug 1, 2024
24 of 27 checks passed
@ykmr1224 ykmr1224 deleted the update-sql-base-parser branch August 2, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants