Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/pit branch to main #2936

Merged
merged 5 commits into from
Aug 15, 2024

Commits on Jun 26, 2024

  1. Add pit for join queries (opensearch-project#2703)

    * Add search after for join
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Enable search after by default
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Add pit
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Fix tests
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * ignore joinWithGeoIntersectNL
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Rerun CI with scroll
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Remove unused code and retrigger CI with search_after true
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Address comments
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Remove unused code change
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Update pit keep alive time with SQL_CURSOR_KEEP_ALIVE
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Fix scroll condition
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Add pit before query execution
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Move pit from join request builder to executor
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Remove unused methods
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Add pit in parent class's run()
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Add comment for fetching subsequent result in NestedLoopsElasticExecutor
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Update comment
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Add javadoc for pit handler
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Add pit interface
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Add pit handler unit test
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Fix failed unit test CI
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Fix spotless error
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Rename pit class and add logs
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Fix pit delete unit test
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    ---------
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    rupal-bq authored Jun 26, 2024
    Configuration menu
    Copy the full SHA
    154cb26 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Merge branch 'main' into feature/pit

    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    rupal-bq committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2a8cade View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into feature/pit

    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    rupal-bq committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6f2aebb View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Add pit for multi query (opensearch-project#2753)

    * Add search after for join
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Enable search after by default
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Add pit
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Fix tests
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * ignore joinWithGeoIntersectNL
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Rerun CI with scroll
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * draft
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Remove unused code and retrigger CI with search_after true
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Address comments
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Remove unused code change
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Update pit keep alive time with SQL_CURSOR_KEEP_ALIVE
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Fix scroll condition
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Add pit before query execution
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Refactor get response with pit method
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Update remaining scroll search calls
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Fix integ test failures
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * nit
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Move pit from join request builder to executor
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Remove unused methods
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Move pit from request to executor
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Fix pit.delete call missed while merge
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Move getResponseWithHits method to util class
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * add try catch for create delete pit in minus executor
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * move all common fields to ElasticHitsExecutor
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * add javadoc for ElasticHitsExecutor
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Add missing javadoc
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    * Forcing an empty commit as last commit is stuck processing updates
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    
    ---------
    
    Signed-off-by: Rupal Mahajan <maharup@amazon.com>
    rupal-bq authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8c6dc0c View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge remote-tracking branch 'upstream/feature/pit' into pit-merge

    Signed-off-by: Manasvini B S <manasvis@amazon.com>
    manasvinibs committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    af4f7aa View commit details
    Browse the repository at this point in the history