Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract validation logic from FlintIndexMetadataServiceImpl #2944

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Extract validation logic from FlintIndexMetadataServiceImpl #2944

merged 1 commit into from
Aug 30, 2024

Conversation

ykmr1224
Copy link
Collaborator

Description

  • Extract validation logic from FlintIndexMetadataServiceImpl
  • This is to make the validation logic usable for async-query-core library user

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • [n/a] New functionality has been documented.
  • New functionality has javadoc added.
  • [n/a] New functionality has a user manual doc added.
  • [n/a] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [n/a] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ykmr1224
Extract validation logic from FlintIndexMetadataServiceImpl
165ae8b 
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@ykmr1224 ykmr1224 added backport 2.x maintenance Improves code quality, but not the product labels Aug 21, 2024
@ykmr1224 ykmr1224 marked this pull request as ready for review August 22, 2024 00:04
vamsi-amazon
vamsi-amazon reviewed Aug 29, 2024
View reviewed changes
async-query-core/src/main/java/org/opensearch/sql/spark/flint/FlintIndexMetadataValidator.java

public static final Set<String> ALTER_TO_FULL_REFRESH_ALLOWED_OPTIONS =
new LinkedHashSet<>(Arrays.asList(AUTO_REFRESH, INCREMENTAL_REFRESH));
public static final Set<String> ALTER_TO_INCREMENTAL_REFRESH_ALLOWED_OPTIONS =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nit] I think these are my changes. Do we need LinkedHashset?

vamsi-amazon
vamsi-amazon approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@vamsi-amazon vamsi-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykmr1224 ykmr1224 merged commit d260e0e into opensearch-project:main Aug 30, 2024
14 of 16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2024
@github-actions
Extract validation logic from FlintIndexMetadataServiceImpl (#2944)
62ac5ca 
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
(cherry picked from commit d260e0e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 30, 2024
Merged
ykmr1224 pushed a commit that referenced this pull request Aug 30, 2024
@opensearch-trigger-bot @github-actions
Extract validation logic from FlintIndexMetadataServiceImpl (#2944) (#…
f51bf56 
…2954)

(cherry picked from commit d260e0e)

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vamsi-amazon vamsi-amazon vamsi-amazon approved these changes

@seankao-az seankao-az seankao-az approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq rupal-bq is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@LantaoJin LantaoJin Awaiting requested review from LantaoJin LantaoJin is a code owner

Assignees
No one assigned
Labels
backport 2.x maintenance Improves code quality, but not the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ykmr1224 @vamsi-amazon @seankao-az