Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag for async query scheduler #2973

Merged

Conversation

noCharger
Copy link
Collaborator

@noCharger noCharger commented Sep 4, 2024

Description

Add feature flag for async query scheduler, which will be passed to Flint to adjust scheduler mode

Also fixed :async-query:jacocoTestCoverageVerification

> Task :async-query:jacocoTestReport
> Task :async-query:jacocoTestCoverageVerification

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • Commits are signed per the DCO using --signoff.

Related Issues

opensearch-project/opensearch-spark#622

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Louis Chu <clingzhi@amazon.com>
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (6c5c685) to head (ec5627f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2973      +/-   ##
============================================
- Coverage     95.18%   94.47%   -0.71%     
- Complexity     4992     5276     +284     
============================================
  Files           459      519      +60     
  Lines         13532    14973    +1441     
  Branches        905     1001      +96     
============================================
+ Hits          12880    14146    +1266     
- Misses          637      780     +143     
- Partials         15       47      +32     
Flag Coverage Δ
sql-engine 94.47% <100.00%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ykmr1224
ykmr1224 previously approved these changes Sep 5, 2024
seankao-az
seankao-az previously approved these changes Sep 5, 2024
Signed-off-by: Louis Chu <clingzhi@amazon.com>
@seankao-az seankao-az merged commit da622eb into opensearch-project:main Sep 5, 2024
13 of 14 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2973-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da622ebd6206b5215f0eceffbbe10218853d6d6d
# Push it to GitHub
git push --set-upstream origin backport/backport-2973-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2973-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.17
# Create a new branch
git switch --create backport/backport-2973-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da622ebd6206b5215f0eceffbbe10218853d6d6d
# Push it to GitHub
git push --set-upstream origin backport/backport-2973-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-2973-to-2.17.

@noCharger
Copy link
Collaborator Author

cherry pick on 2.x faild because #2952 is not in 2.x

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.17
# Create a new branch
git switch --create backport/backport-2973-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da622ebd6206b5215f0eceffbbe10218853d6d6d
# Push it to GitHub
git push --set-upstream origin backport/backport-2973-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-2973-to-2.17.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
* Add feature flag for async query scheduler

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix Jacoco verification

Signed-off-by: Louis Chu <clingzhi@amazon.com>

---------

Signed-off-by: Louis Chu <clingzhi@amazon.com>
(cherry picked from commit da622eb)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
noCharger added a commit to noCharger/sql that referenced this pull request Sep 5, 2024
* Add feature flag for async query scheduler

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix Jacoco verification

Signed-off-by: Louis Chu <clingzhi@amazon.com>

---------

Signed-off-by: Louis Chu <clingzhi@amazon.com>
(cherry picked from commit da622eb)
seankao-az pushed a commit that referenced this pull request Sep 5, 2024
* Add feature flag for async query scheduler



* Fix Jacoco verification



---------


(cherry picked from commit da622eb)

Signed-off-by: Louis Chu <clingzhi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
seankao-az pushed a commit that referenced this pull request Sep 5, 2024
)

* Add feature flag for async query scheduler (#2973)

* Add feature flag for async query scheduler

Signed-off-by: Louis Chu <clingzhi@amazon.com>

* Fix Jacoco verification

Signed-off-by: Louis Chu <clingzhi@amazon.com>

---------

Signed-off-by: Louis Chu <clingzhi@amazon.com>
(cherry picked from commit da622eb)

* Fix type mismatch

Signed-off-by: Louis Chu <clingzhi@amazon.com>

---------

Signed-off-by: Louis Chu <clingzhi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants