-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag for async query scheduler #2973
Add feature flag for async query scheduler #2973
Conversation
a5e530f
to
2e98c79
Compare
Signed-off-by: Louis Chu <clingzhi@amazon.com>
2e98c79
to
ec5627f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2973 +/- ##
============================================
- Coverage 95.18% 94.47% -0.71%
- Complexity 4992 5276 +284
============================================
Files 459 519 +60
Lines 13532 14973 +1441
Branches 905 1001 +96
============================================
+ Hits 12880 14146 +1266
- Misses 637 780 +143
- Partials 15 47 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Louis Chu <clingzhi@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2973-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da622ebd6206b5215f0eceffbbe10218853d6d6d
# Push it to GitHub
git push --set-upstream origin backport/backport-2973-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.17
# Create a new branch
git switch --create backport/backport-2973-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da622ebd6206b5215f0eceffbbe10218853d6d6d
# Push it to GitHub
git push --set-upstream origin backport/backport-2973-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.17 Then, create a pull request where the |
cherry pick on 2.x faild because #2952 is not in 2.x |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.17
# Create a new branch
git switch --create backport/backport-2973-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da622ebd6206b5215f0eceffbbe10218853d6d6d
# Push it to GitHub
git push --set-upstream origin backport/backport-2973-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.17 Then, create a pull request where the |
* Add feature flag for async query scheduler Signed-off-by: Louis Chu <clingzhi@amazon.com> * Fix Jacoco verification Signed-off-by: Louis Chu <clingzhi@amazon.com> --------- Signed-off-by: Louis Chu <clingzhi@amazon.com> (cherry picked from commit da622eb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add feature flag for async query scheduler Signed-off-by: Louis Chu <clingzhi@amazon.com> * Fix Jacoco verification Signed-off-by: Louis Chu <clingzhi@amazon.com> --------- Signed-off-by: Louis Chu <clingzhi@amazon.com> (cherry picked from commit da622eb)
* Add feature flag for async query scheduler * Fix Jacoco verification --------- (cherry picked from commit da622eb) Signed-off-by: Louis Chu <clingzhi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) * Add feature flag for async query scheduler (#2973) * Add feature flag for async query scheduler Signed-off-by: Louis Chu <clingzhi@amazon.com> * Fix Jacoco verification Signed-off-by: Louis Chu <clingzhi@amazon.com> --------- Signed-off-by: Louis Chu <clingzhi@amazon.com> (cherry picked from commit da622eb) * Fix type mismatch Signed-off-by: Louis Chu <clingzhi@amazon.com> --------- Signed-off-by: Louis Chu <clingzhi@amazon.com>
Description
Add feature flag for async query scheduler, which will be passed to Flint to adjust scheduler mode
Also fixed
:async-query:jacocoTestCoverageVerification
Check List
--signoff
.Related Issues
opensearch-project/opensearch-spark#622
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.