-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change master nomenclature #551
Change master nomenclature #551
Conversation
Signed-off-by: Chen Dai <daichen@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np. master
in github links can usually be replaced with HEAD
, so it always points to latest commit on the default branch even if default branch changed. but i think it's not necessary
good to know that. thanks! |
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
=============================================
- Coverage 94.59% 62.76% -31.83%
=============================================
Files 276 10 -266
Lines 7454 658 -6796
Branches 550 118 -432
=============================================
- Hits 7051 413 -6638
+ Misses 349 192 -157
+ Partials 54 53 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Chen Dai <daichen@amazon.com>
Signed-off-by: Chen Dai daichen@amazon.com
Description
Change master nomenclature: Change
master
(mostly Github link) tomain
in docs and comments.The only code using master nomenclature is in OpenSearch API call which doesn't seem have alternative clusterManager class or method:
The following
master
in doc link are also not changed due tomain
branch missing:PR reference:
Issues Resolved
#463
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.