-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable ci for windows and macos #907
Merged
derek-ho
merged 26 commits into
opensearch-project:2.x
from
derek-ho:enable-windows-macos
Oct 25, 2022
+553
−532
Merged
Changes from 23 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
2661232
initial commit for sql workbench windows and macos
derek-ho 7a1c7ae
name files
derek-ho ef535e9
clean up code with matrix
derek-ho 8a58eb9
forgot comma
derek-ho 828101c
use cross env for windows and enable windows and macos ci in sql
derek-ho 53ef534
disable integration and jacoco for windows and mac
derek-ho 7569d6d
add gitattributes file to normalize line endings
derek-ho 912731b
move gitattributes into appropriate folder
derek-ho 6a6cfd6
configure line endings for windows
derek-ho 0d016ef
fix one test file and get rid of git attributes
derek-ho a8709d2
disable doctest and integ test
derek-ho d4c9f1e
fix up tests
derek-ho 9df2acd
fix tests and add java docs
derek-ho 8f98fa4
revert error format
derek-ho 7a39dcb
revert pretty format response
derek-ho bd8572a
revert error formatter test file
derek-ho a2b473b
replace carriage return with nothing
derek-ho a3747a3
remove windows git config
derek-ho e70df11
fix PR comments and fail test on purpose to see if upload test report…
derek-ho de65184
fix matrix entry
derek-ho a6f3ceb
remove test failure
derek-ho 3f372bb
fix up to run on right os
derek-ho 5e24f3c
fix up indentation
derek-ho 3fbe3e4
remove env. build_args to make it cleaner
derek-ho 954c072
try removing env var
derek-ho 79f765c
remove unecessary import
derek-ho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -19,26 +19,35 @@ on: | |||||
|
||||||
jobs: | ||||||
build: | ||||||
env: | ||||||
BUILD_ARGS: ${{ matrix.entry.os_build_args }} | ||||||
strategy: | ||||||
# Run all jobs | ||||||
fail-fast: false | ||||||
matrix: | ||||||
java: | ||||||
- 11 | ||||||
- 17 | ||||||
runs-on: ubuntu-latest | ||||||
entry: | ||||||
- { os: ubuntu-latest, java: 11 } | ||||||
- { os: windows-latest, java: 11, os_build_args: -x doctest -x integTest -x jacocoTestReport -x compileJdbc} | ||||||
- { os: macos-latest, java: 11, os_build_args: -x doctest -x integTest -x jacocoTestReport -x compileJdbc } | ||||||
- { os: ubuntu-latest, java: 17 } | ||||||
- { os: windows-latest, java: 17, os_build_args: -x doctest -x integTest -x jacocoTestReport -x compileJdbc } | ||||||
- { os: macos-latest, java: 17, os_build_args: -x doctest -x integTest -x jacocoTestReport -x compileJdbc } | ||||||
runs-on: ${{ matrix.entry.os }} | ||||||
|
||||||
steps: | ||||||
- uses: actions/checkout@v3 | ||||||
|
||||||
- name: Set up JDK ${{ matrix.java }} | ||||||
uses: actions/setup-java@v3 | ||||||
with: | ||||||
distribution: 'temurin' | ||||||
java-version: ${{ matrix.java }} | ||||||
java-version: ${{ matrix.entry.java }} | ||||||
|
||||||
- name: Build with Gradle | ||||||
run: ./gradlew --continue build assemble | ||||||
run: ./gradlew --continue build ${{ env.BUILD_ARGS }} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can use there
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're right this is cleaner let me do this |
||||||
|
||||||
- name: Run backward compatibility tests | ||||||
if: ${{ matrix.entry.os == 'ubuntu-latest' }} | ||||||
run: ./scripts/bwctest.sh | ||||||
|
||||||
- name: Create Artifact Path | ||||||
|
@@ -48,7 +57,7 @@ jobs: | |||||
|
||||||
# This step uses the codecov-action Github action: https://github.com/codecov/codecov-action | ||||||
- name: Upload SQL Coverage Report | ||||||
if: always() | ||||||
if: ${{ always() && matrix.entry.os == 'ubuntu-latest' }} | ||||||
uses: codecov/codecov-action@v3 | ||||||
with: | ||||||
flags: sql-engine | ||||||
|
@@ -57,11 +66,11 @@ jobs: | |||||
- name: Upload Artifacts | ||||||
uses: actions/upload-artifact@v2 | ||||||
with: | ||||||
name: opensearch-sql | ||||||
name: opensearch-sql-${{ matrix.entry.os }} | ||||||
path: opensearch-sql-builds | ||||||
|
||||||
- name: Upload test reports | ||||||
if: always() | ||||||
if: ${{ always() && matrix.entry.os == 'ubuntu-latest' }} | ||||||
uses: actions/upload-artifact@v2 | ||||||
with: | ||||||
name: test-reports | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is assemble unnecessary here? It seems build includes assemble:
https://stackoverflow.com/a/44185464