Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fundamental logger mechanism #16

Open
sczyh30 opened this issue Nov 3, 2022 · 1 comment · May be fixed by #19
Open

Add fundamental logger mechanism #16

sczyh30 opened this issue Nov 3, 2022 · 1 comment · May be fixed by #19
Labels
area/logging Issue related to logging kind/feature Category issues or PRs related to feature request.

Comments

@sczyh30
Copy link
Member

sczyh30 commented Nov 3, 2022

Add fundamental logger mechanism.

目前 OpenSergo 控制面的日志机制非常简单，复用了 Sentinel Go 的日志模块。我们需要设计一个通用的 logger 机制与基本实现，并支持任意扩展。
@sczyh30 sczyh30 added kind/feature Category issues or PRs related to feature request. area/logging Issue related to logging labels Nov 3, 2022
@sczyh30 sczyh30 mentioned this issue Nov 3, 2022
Open
jnan806 added a commit to jnan806/opensergo-control-plane that referenced this issue Nov 3, 2022
@jnan806
feature: Add fundamental logger mechanism (opensergo#16)
8ed6dad
@jnan806 jnan806 linked a pull request Nov 3, 2022 that will close this issue
Open
jnan806 added a commit to jnan806/opensergo-control-plane that referenced this issue Nov 3, 2022
@jnan806
feature: Add fundamental logger mechanism (opensergo#16)
7080a79 
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
jnan806 added a commit to jnan806/opensergo-control-plane that referenced this issue Nov 4, 2022
@jnan806
feature: Add fundamental logger mechanism (opensergo#16)
b9b1f76 
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
jnan806 added a commit to jnan806/opensergo-control-plane that referenced this issue Nov 7, 2022
@jnan806
feature: Add fundamental logger mechanism (opensergo#16)
7cb4f66 
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
jnan806 added a commit to jnan806/opensergo-control-plane that referenced this issue Nov 10, 2022
@jnan806
Add fundamental logger mechanism (opensergo#16)
8110950 
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
@wuxuer
Copy link

wuxuer commented Nov 27, 2022

Maybe we can introduce zap as the basic log component, for details, please refer to: https://github.com/uber-go/zap.
And create a common package logger, which is an adapter around zap and provides structured logging capabilities.

@garroshh garroshh mentioned this issue Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/logging Issue related to logging kind/feature Category issues or PRs related to feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: Add fundamental logger mechanism (#16) jnan806/opensergo-control-plane
2 participants
@wuxuer @sczyh30