Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unsubscribe config | 控制面支持取消订阅配置 #7

Open
sczyh30 opened this issue Sep 25, 2022 · 1 comment · May be fixed by #20
Open

Support unsubscribe config | 控制面支持取消订阅配置 #7

sczyh30 opened this issue Sep 25, 2022 · 1 comment · May be fixed by #20
Assignees
@jnan806
Labels
area/crd-watcher Category issues or PRs related to CRD watcher good first issue Good for newcomers kind/feature Category issues or PRs related to feature request.

Comments

@sczyh30
Copy link
Member

sczyh30 commented Sep 25, 2022 •
edited

控制面支持取消订阅（unsubscribe）某个 target 的配置。取消订阅的语义如下：

  • 取消订阅由 client 发起 SubscribeConfig request，其中 opType=UNSUBSCRIBE
  • Control plane 将该连接从该订阅组中移除；特别地，若该订阅组中已无连接（即发起 unsubscribe 的为最后一个订阅的连接），则 control plane 可以在一段静默期后从 CRD watcher 取消该分组的订阅关系。

Support unsubscribe OpenSergo config. Add a handler for the unsubscribe request.
@sczyh30 sczyh30 added the kind/feature Category issues or PRs related to feature request. label Sep 25, 2022
@sczyh30 sczyh30 changed the title Support unsubscribe config Support unsubscribe config | 控制面支持取消订阅配置 Nov 3, 2022
@sczyh30 sczyh30 added the good first issue Good for newcomers label Nov 3, 2022
@jnan806
Copy link
Collaborator

jnan806 commented Nov 3, 2022

I want to contribute it. Please assign to me if nobody was assigned. Thanks ~

jnan806 added a commit to jnan806/opensergo-control-plane that referenced this issue Nov 7, 2022
@jnan806
support unsubscribe. (opensergo#7)
07d9a80 
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
@jnan806 jnan806 linked a pull request Nov 7, 2022 that will close this issue
Draft
jnan806 added a commit to jnan806/opensergo-control-plane that referenced this issue Nov 7, 2022
@jnan806
support unsubscribe. (opensergo#7)
263a15d 
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
@sczyh30 sczyh30 added the area/crd-watcher Category issues or PRs related to CRD watcher label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnan806 jnan806

Labels
area/crd-watcher Category issues or PRs related to CRD watcher good first issue Good for newcomers kind/feature Category issues or PRs related to feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support unsubscribe jnan806/opensergo-control-plane
2 participants
@sczyh30 @jnan806