Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint check for OpenSergoClient #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jnan806
Copy link
Collaborator

@jnan806 jnan806 commented Feb 14, 2023

Signed-off-by: Jiangnan Jia jnan0806@gmail.com

Describe what this PR does / why we need it

Add condition ckeck for OpenSergoClient.Builder.build()

@jnan806 jnan806 changed the title Add condition ckeck for OpenSergoClient.Builder.build() Add empty check for host in OpenSergoClient Feb 14, 2023
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the provided port is invalid?

@jnan806 jnan806 force-pushed the client_build_check branch 2 times, most recently from 2ea0ba3 to bc79ac1 Compare February 15, 2023 08:31
@jnan806
Copy link
Collaborator Author

jnan806 commented Feb 15, 2023

What if the provided port is invalid?

:) has improved, both host and port of endpoint will be checked

@jnan806 jnan806 changed the title Add empty check for host in OpenSergoClient Add endpoint check for OpenSergoClient Feb 15, 2023
Signed-off-by: Jiangnan Jia <jnan0806@gmail.com>
@jnan806 jnan806 requested a review from sczyh30 March 14, 2023 02:52
@jnan806 jnan806 added the kind/enhancement Category issues or PRs related to enhancement label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or PRs related to enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants