-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/plan names can be "-" #305
Comments
While for service this concern is valid, for the plans it most probably just means that the service has one and only "default" plan. If we want a better UX for such services, we can probably make plan list optional? |
As mentioned in #154, would it make sense to eventually include a regex of valid names and ID's? Regexes can be ugly, but I think we have spent way too much time already discussing which character/formats should be allowed. |
an easy way is to change the text to say something like " |
Unfortunately I don't think we can ban it via a MUST NOT, but I think some guidance text against it would be good. I'll work on it. |
Closes openservicebrokerapi#305 Signed-off-by: Doug Davis <dug@us.ibm.com>
For v3 do we want a backwards-incompatible change that forbids these kind of names? |
Maybe a little bit yes - e.g. restrict it to [a-z0-9][-a-z0-9]* wouldn't be overly restrictive. But we can discuss when we get to v3. |
Closes openservicebrokerapi#305 Signed-off-by: Doug Davis <dug@us.ibm.com>
Closes openservicebrokerapi#305 Signed-off-by: Doug Davis <dug@us.ibm.com>
we should probably add something about how "-" isn't a good choice for a name :-)
The text was updated successfully, but these errors were encountered: