Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/plan names can be "-" #305

Closed
duglin opened this issue Aug 31, 2017 · 6 comments
Closed

service/plan names can be "-" #305

duglin opened this issue Aug 31, 2017 · 6 comments
Assignees

Comments

@duglin
Copy link
Contributor

duglin commented Aug 31, 2017

we should probably add something about how "-" isn't a good choice for a name :-)

@nilebox
Copy link

nilebox commented Sep 1, 2017

While for service this concern is valid, for the plans it most probably just means that the service has one and only "default" plan.

If we want a better UX for such services, we can probably make plan list optional?

@angarg12
Copy link
Contributor

angarg12 commented Sep 1, 2017

As mentioned in #154, would it make sense to eventually include a regex of valid names and ID's?

Regexes can be ugly, but I think we have spent way too much time already discussing which character/formats should be allowed.

@n3wscott
Copy link
Contributor

an easy way is to change the text to say something like "- is allowed when surrounded by alphanumeric characters" or something like that.

@duglin duglin self-assigned this Oct 17, 2017
@duglin
Copy link
Contributor Author

duglin commented Oct 17, 2017

Unfortunately I don't think we can ban it via a MUST NOT, but I think some guidance text against it would be good. I'll work on it.

duglin pushed a commit to duglin/servicebroker that referenced this issue Jan 22, 2018
Closes openservicebrokerapi#305

Signed-off-by: Doug Davis <dug@us.ibm.com>
@angarg12
Copy link
Contributor

For v3 do we want a backwards-incompatible change that forbids these kind of names?

@duglin
Copy link
Contributor Author

duglin commented Jan 22, 2018

Maybe a little bit yes - e.g. restrict it to [a-z0-9][-a-z0-9]* wouldn't be overly restrictive. But we can discuss when we get to v3.

duglin pushed a commit to duglin/servicebroker that referenced this issue Jan 22, 2018
Closes openservicebrokerapi#305

Signed-off-by: Doug Davis <dug@us.ibm.com>
mihnjong pushed a commit to mihnjong/servicebroker that referenced this issue Jan 29, 2018
Closes openservicebrokerapi#305

Signed-off-by: Doug Davis <dug@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants