Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCO check #3

Merged
merged 1 commit into from
Jul 11, 2016
Merged

Add DCO check #3

merged 1 commit into from
Jul 11, 2016

Conversation

duglin
Copy link
Contributor

@duglin duglin commented Jul 11, 2016

Add a travis-ci check to ensure all PR's commits are signed with a DCO.

@duglin duglin force-pushed the addDCOCheck branch 7 times, most recently from bbb6f8c to ae2afc9 Compare July 11, 2016 19:01
@MHBauer
Copy link
Contributor

MHBauer commented Jul 11, 2016

Can you add a definition of what this means?

@duglin
Copy link
Contributor Author

duglin commented Jul 11, 2016

@MHBauer Done

@duglin duglin force-pushed the addDCOCheck branch 2 times, most recently from 04a3eb4 to c39de1c Compare July 11, 2016 19:16
Signed-off-by: Doug Davis <dug@us.ibm.com>
@MHBauer
Copy link
Contributor

MHBauer commented Jul 11, 2016

I'm not sure what you changed, but to be explicit:

  1. define DCO
  2. explain or link to what it means to agree to it
  3. explain how to do it (git commit -s)
  4. explain that signing off means you are agreeing to the dco

I can do research, but we shouldn't make people do research, or blow off the significance of what signing off is intending to mean.

@duglin duglin merged commit b191d08 into openservicebrokerapi:master Jul 11, 2016
@duglin duglin deleted the addDCOCheck branch July 11, 2016 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants