Allow uppercase chars in service and plan names #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey duglin! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
LGTM |
jwforres
reviewed
Jan 30, 2018
spec.md
Outdated
| @@ -353,7 +359,7 @@ It is therefore RECOMMENDED that implementations avoid such strings. | |||
|
|
|||
| | Response field | Type | Description | | |||
| | --- | --- | --- | | |||
| | name* | string | A CLI-friendly name of the service. MUST only contain lowercase characters, numbers and hyphens (no spaces). MUST be unique across all service objects returned in this response. MUST be a non-empty string. | | |||
| | name* | string | A CLI-friendly name of the service. MUST only contain alphanumerica characters and hyphens (no spaces). MUST be unique across all service objects returned in this response. MUST be a non-empty string. | | |||
|
LGTM |
Closes openservicebrokerapi#422 Signed-off-by: Doug Davis <dug@us.ibm.com>
|
fixed typo and added text around how names are now case-sensitive |
|
re-reviews needed due to minor tweaks |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #422
Signed-off-by: Doug Davis dug@us.ibm.com