Add guidance for supported string lengths #518
Conversation
|
Hey mattmcneeney! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
LGTM |
| Platforms MAY have limits on the length of strings that they can handle or | ||
| display to end users, such as the description of a Service or Service Plan. It | ||
| is RECOMMENDED that strings do not exceed 255 characters to increase the | ||
| likelihood of having compatibility with any Platform. |
There was a problem hiding this comment.
Sorry to sandbag one more comment, but perhaps we want to give an out to the platform for truncation? like:
Platforms MAY truncate strings longer than 255 characters. or something like that. This says the platforms have limits as a warning to the broker but does not say what the platform will do to a string from a broker that is too long.
There was a problem hiding this comment.
My concern with that sentence is that it may make service authors think that Platforms would still be compatible (as in, they could use the service broker), but in CFs case, a string over 255 characters means you can't register the broker at all.
|
Needs reviews! |
|
@mattmcneeney stop using the service broker repo for development. Make a fork in your own space and make PRs from there :D |
|
@n3wscott Ha I didn't even realise I was doing that... Serves me right for editing in the browser! |
|
lgtm |
|
LGTM |
See #509