Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify plan id for polling last operation after an update #522

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Clarify plan id for polling last operation after an update #522

merged 1 commit into from
Jul 12, 2018

Conversation

mattmcneeney
Copy link
Contributor

Resolves #396

@cfdreddbot
Copy link

Hey mattmcneeney!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@duglin
Copy link
Contributor

duglin commented May 23, 2018 •
edited by avade

LGTM

I don't think we have a choice since the op may fail

Approved with PullApprove

@mattmcneeney
Copy link
Contributor Author

@n3wscott to change svc-cat to use the old plan_id before we merge this (hopefully this week)

@duglin
Copy link
Contributor

duglin commented Jul 12, 2018 •
edited by avade

LGTM

Approved with PullApprove

@zrob
Copy link
Member

zrob commented Jul 12, 2018 •
edited by avade

lgtm

Approved with PullApprove

@n3wscott
Copy link
Contributor

n3wscott commented Jul 12, 2018 •
edited by avade

Service Catalog still does the old way. This will have to be updated.

LGTM

Approved with PullApprove

@mattmcneeney mattmcneeney merged commit a233c97 into openservicebrokerapi:master Jul 12, 2018
@mattmcneeney mattmcneeney deleted the clarify-plan-id-for-update branch July 12, 2018 21:10
@teddyking teddyking mentioned this pull request Mar 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmui fmui fmui approved these changes

@n3wscott n3wscott n3wscott approved these changes

@pmorie pmorie Awaiting requested review from pmorie

@zrob zrob Awaiting requested review from zrob

@kibbles-n-bytes kibbles-n-bytes Awaiting requested review from kibbles-n-bytes

@vaikas vaikas Awaiting requested review from vaikas

Assignees
No one assigned
Labels
3 - reviewing PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mattmcneeney @cfdreddbot @duglin @zrob @n3wscott @fmui