Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Implement SMI Metrics #379

Closed
3 of 4 tasks
snehachhabria opened this issue Mar 27, 2020 · 7 comments
Closed
3 of 4 tasks

Implement SMI Metrics #379

snehachhabria opened this issue Mar 27, 2020 · 7 comments
Assignees
Labels
area/metrics Metrics related area/SMI SMI implementation related priority/P2 P2 priority size/L 14 days (~2.5 weeks)

Comments

@snehachhabria
Copy link
Contributor

snehachhabria commented Mar 27, 2020

this will help extending the k8s API for users to make metrics requests (for resource defined in SMI spec)

@michelleN michelleN added the MVP label Apr 10, 2020
@michelleN michelleN added this to the v0.0.4 milestone Apr 13, 2020
@michelleN michelleN added the size/L 14 days (~2.5 weeks) label Apr 16, 2020
@michelleN michelleN changed the title Integrate SMI Metrics API and SMI spec with OSM Implement SMI Metrics API for OSM May 1, 2020
@michelleN
Copy link
Contributor

blocked by #563
We need to figure out how to compose the service level metrics before we can build out the smi metrics implementation fully.

@michelleN michelleN modified the milestones: v0.0.4, v0.0.5 May 1, 2020
@michelleN
Copy link
Contributor

Once we've completed the research on how to get envoy to emit the metrics/metadata we need, we'll also need to create an issue for doing the work to implement those things.

@michelleN michelleN modified the milestones: v0.0.5, v0.0.6 May 4, 2020
@michelleN michelleN modified the milestones: v0.0.6, v0.0.7 May 28, 2020
@michelleN michelleN added this to the v0.0.8 milestone Jun 11, 2020
@phillipgibson phillipgibson added the area/metrics Metrics related label Jun 24, 2020
@phillipgibson phillipgibson removed this from the v0.0.8 milestone Jun 26, 2020
@michelleN
Copy link
Contributor

michelleN commented Jul 2, 2020

[Task list moved to description]

@jshaughn
Copy link

Hi @michelleN . does this open issue mean that OSM does not yet make request metrics available for consumption?

@nojnhuh nojnhuh added this to the v0.3.0 milestone Aug 17, 2020
@SanyaKochhar SanyaKochhar added area/SMI SMI implementation related and removed MVP labels Aug 26, 2020
@michelleN michelleN added this to the v0.4.0 milestone Sep 17, 2020
@michelleN michelleN removed this from the v0.4.0 milestone Sep 29, 2020
@michelleN
Copy link
Contributor

@jshaughn - OSM does make available metrics around success/error rate and latency available and you can view them already via the osm dashboard command. The SMI metrics spec requires us to compute some more granular metrics between a source and destination (for example between a two specific Pods or Deployments) so that is what is being done with this work.

@jshaughn
Copy link

@michelleN Thanks for the response. Pod-specific metrics are less interesting given the more dynamic nature of pods but the traffic for more logical aggregations of pods, like Deployments, is what I was looking for.

@michelleN michelleN added this to the v0.8.0 milestone Jan 29, 2021
@michelleN michelleN added the priority/P1 P1 priority label Feb 12, 2021
@draychev draychev modified the milestones: v0.8.0, v0.9.0 Mar 1, 2021
@draychev draychev modified the milestones: v0.9.0, v0.10.0 May 5, 2021
@draychev draychev mentioned this issue Jun 30, 2021
10 tasks
@draychev draychev modified the milestones: v0.10.0, vNext Aug 23, 2021
@draychev draychev added priority/P2 P2 priority and removed priority/P1 P1 priority labels Aug 23, 2021
@snehachhabria snehachhabria removed this from the vNext milestone Feb 2, 2022
@snehachhabria
Copy link
Contributor Author

closing this issue as we have an implementation of smi metrics already.

mudit-01 added a commit to mudit-01/osm that referenced this issue Mar 2, 2022
openservicemesh#379 is closed hence removing the "In Progress" comment from https://github.com/openservicemesh/osm#smi-specification-support

Signed-off-by: mudit singh <mudit.singh@india.nec.com>
jaellio pushed a commit that referenced this issue Mar 8, 2022
#379 is closed hence
removing the reference to the issue from
https://github.com/openservicemesh/osm#smi-specification-support.
Leaving the "In Progress" comment until OSM is added to SMI's metrics
server.

Signed-off-by: mudit singh <mudit.singh@india.nec.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/metrics Metrics related area/SMI SMI implementation related priority/P2 P2 priority size/L 14 days (~2.5 weeks)
Projects
None yet
Development

No branches or pull requests

7 participants