Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Update TrafficSplit version from v1alphav2 to v1alpha4 #705

Closed
snehachhabria opened this issue May 26, 2020 · 5 comments
Closed

Update TrafficSplit version from v1alphav2 to v1alpha4 #705

snehachhabria opened this issue May 26, 2020 · 5 comments
Labels
area/SMI SMI implementation related size/XL 20 days (4 weeks)

Comments

@snehachhabria
Copy link
Contributor

snehachhabria commented May 26, 2020

SMI has a new version of TrafficSplit, OSM needs to be updated to use this version.

Note: The main feature available with this latest version is that it enables the use of TrafficSpec with TrafficSplit. This upgrade isn't mandatory as we are updating TrafficSpec with #449 so all its features could be used with a TrafficTarget

We can work on this item once we get more clarity from the PMs if it is an immediate requirement for add-on or open source

@ksubrmnn ksubrmnn added this to the v0.0.7 milestone Jun 2, 2020
@ksubrmnn ksubrmnn self-assigned this Jun 2, 2020
@michelleN
Copy link
Contributor

  • identify there is a conflict between policy and split, then figure out how to program Envoys in the scenario of where policy enforcement prevents split.
  • how to bubble up errors and give feedback to user

We'll continue to discus with SMI community how to handle these scenarios in a standardized way.

@michelleN michelleN modified the milestones: v0.0.7, v0.0.8 Jun 11, 2020
@ksubrmnn ksubrmnn modified the milestones: v0.0.8, v0.0.9 Jun 25, 2020
@ksubrmnn ksubrmnn added the kind/research-required Requires further research to make progress label Jun 25, 2020
@ksubrmnn
Copy link
Contributor

ksubrmnn commented Jul 1, 2020

Currently blocked on new SMI release with v1alpha3 updates

@ksubrmnn ksubrmnn modified the milestones: v0.0.9, v0.0.10 Jul 10, 2020
@lachie83 lachie83 modified the milestones: v0.0.10, v0.1.0-rc.1 Jul 28, 2020
@ksubrmnn ksubrmnn linked a pull request Jul 31, 2020 that will close this issue
@phillipgibson phillipgibson removed this from the v0.1.0-rc.1 milestone Aug 5, 2020
@michelleN michelleN added this to the v0.3.0 milestone Aug 9, 2020
@SanyaKochhar SanyaKochhar added P1 area/SMI SMI implementation related labels Aug 28, 2020
@michelleN michelleN modified the milestones: v0.3.0, v0.4.0 Sep 17, 2020
@draychev draychev added P2 and removed P1 labels Sep 25, 2020
@michelleN michelleN removed this from the v0.4.0 milestone Sep 29, 2020
@michelleN michelleN self-assigned this Oct 26, 2020
@michelleN michelleN removed the kind/research-required Requires further research to make progress label Oct 26, 2020
@michelleN
Copy link
Contributor

michelleN commented Oct 26, 2020

Had a few meetings with @ksubrmnn @shashankram @draychev @snehachhabria and this is what came out of those. (Please feel free to comment)

To implement this in a way where routes associated with a traffic target are decoupled from a traffic split, we need to do the following steps in order:

  1. Relax logic on how outbound routes get programmed. Outbound routes for clusters should be programmed with wildcard routes.
  2. Ensure that routes are programmed via RDS on the server side/inbound clusters(already happening).
  3. Any time an SMI traffic split is applied, create an outbound virtual host with weighted cluster information on client with routes pointing to the backends of that traffic split.
  4. Apply route information (SMI Traffic Split rules / HTTPRouteGroup) to the virutal host for that traffic split.

@michelleN
Copy link
Contributor

Currently blocked on #2034

@michelleN michelleN removed this from the v0.7.0 milestone Dec 8, 2020
@snehachhabria snehachhabria changed the title Update TrafficSplit version from v1alphav2 to v1alphav3 Update TrafficSplit version from v1alphav2 to v1alphav4 Feb 10, 2021
@snehachhabria snehachhabria changed the title Update TrafficSplit version from v1alphav2 to v1alphav4 Update TrafficSplit version from v1alphav2 to v1alpha4 Feb 10, 2021
@snehachhabria
Copy link
Contributor Author

closing this issue cause of duplicate issue #2368

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/SMI SMI implementation related size/XL 20 days (4 weeks)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants