Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

chore(pkg/kubetnetes) : Convert tests to use Go std testing library #2782

Merged
merged 1 commit into from
Mar 9, 2021
Merged

chore(pkg/kubetnetes) : Convert tests to use Go std testing library #2782

merged 1 commit into from
Mar 9, 2021

Conversation

snehachhabria
Copy link
Contributor

@snehachhabria snehachhabria commented Mar 9, 2021 •
edited
Loading

Description:

Convert tests in util_test.go to use Go std testing library

Part of : #1704

Signed-off-by: Sneha Chhabria snchh@microsoft.com

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [X]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? no

@snehachhabria
chore(pkg/kubetnetes) : Convert tests to use Go std testing library
5a0ad9c 
Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria requested a review from a team as a code owner March 9, 2021 19:56
eduser25
eduser25 approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@eduser25 eduser25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so much this

@snehachhabria snehachhabria merged commit 9535bf7 into openservicemesh:main Mar 9, 2021
@snehachhabria snehachhabria deleted the updateToGoTest branch March 30, 2021 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nojnhuh nojnhuh nojnhuh approved these changes

@eduser25 eduser25 eduser25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snehachhabria @eduser25 @nojnhuh