Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

chore(tlsversion): Add a tls minimum version for webhooks #4229

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

snehachhabria
Copy link
Contributor

Description:

Add a minimum tls version for webhooks

fixed #4165

Signed-off-by: Sneha Chhabria snchh@microsoft.com

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

Add a minimum tls version for webhooks

fixed openservicemesh#4165

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria requested a review from a team as a code owner October 7, 2021 20:44
@codecov-commenter
Copy link

Codecov Report

Merging #4229 (2e1ebea) into main (33336c6) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4229      +/-   ##
==========================================
+ Coverage   69.51%   69.57%   +0.06%     
==========================================
  Files         211      211              
  Lines       11427    11434       +7     
==========================================
+ Hits         7943     7955      +12     
+ Misses       3435     3430       -5     
  Partials       49       49              
Flag Coverage Δ
unittests 69.57% <50.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/health/health.go 59.61% <0.00%> (-3.65%) ⬇️
pkg/crdconversion/crdconversion.go 75.75% <100.00%> (+5.34%) ⬆️
pkg/injector/webhook.go 90.32% <100.00%> (+0.03%) ⬆️
pkg/utils/mtls.go 100.00% <100.00%> (ø)
pkg/validator/server.go 78.64% <100.00%> (+0.20%) ⬆️
pkg/certificate/rotor/rotor.go 87.50% <0.00%> (+3.12%) ⬆️
pkg/messaging/workqueue.go 100.00% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33336c6...2e1ebea. Read the comment docs.

@snehachhabria snehachhabria merged commit 9572b52 into openservicemesh:main Oct 7, 2021
@snehachhabria snehachhabria deleted the tlsVersion branch October 14, 2021 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set minimum TLS version in webhooks
4 participants