This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
rate-limiting: add HTTP local rate limiting capability #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashankram
requested review from
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
- Adds capability to locally (per sidecar) rate limit HTTP traffic - Adds HTTP rate limit e2e test - Clarifies allowed HTTP status codes for rate limited responses Part of openservicemesh#2018 Signed-off-by: Shashank Ram <shashr2204@gmail.com>
trstringer
approved these changes
Jun 24, 2022
allenlsy
reviewed
Jun 24, 2022
| Expect(err).ToNot((HaveOccurred())) | ||
|
|
||
| // Expect client to receive 429 (Too Many Requests) | ||
| cond = Td.WaitForRepeatedSuccess(func() bool { |
There was a problem hiding this comment.
Alternatively, we can use the fortio toolkit to set traffic RPS and test rate limiting.
There was a problem hiding this comment.
Yep, this was a lot easier though to test the basic scenario.
allenlsy
approved these changes
Jun 24, 2022
jaellio
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds capability to locally (per sidecar) rate limit
HTTP traffic
Adds HTTP rate limit e2e test
Clarifies allowed HTTP status codes for rate limited
responses
Part of #2018
Testing done:
Unit tests, e2e tests
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
noHas documentation corresponding to this change been updated in the osm-docs repo (if applicable)?
will be updated post merge